eileen-sr/locomotive
1
0
Fork 2
Code Issues Pull requests 1 Releases 1 Activity

feat: better log output for wine #2

Open
navi10 wants to merge 1 commit from navi10/locomotive:wine_log into master
pull from: navi10/locomotive:wine_log
merge into: eileen-sr:master
Conversation 1 Commits 1 Files changed 2 +80 -3
navi10 commented 2026-03-22 15:05:52 +00:00
First-time contributor
Copy link
No description provided.
xeon requested changes 2026-03-22 15:15:32 +00:00
src/root.zig Outdated
@ -1,4 +1,4 @@
const log = std.log.scoped(.locomotive);
const log = debug.scoped(.locomotive);
xeon commented 2026-03-22 15:14:39 +00:00
Owner
Copy link

Instead of swapping entire std.log functionality, consider overriding the implementation through std.Options - it has a logFn field.

Instead of swapping entire std.log functionality, consider overriding the implementation through std.Options - it has a logFn field.
navi10 commented 2026-03-22 15:23:44 +00:00
Author
First-time contributor
Copy link

I tried logFn field but idk why it didn't work

I tried logFn field but idk why it didn't work
xeon commented 2026-03-22 15:25:40 +00:00
Owner
Copy link

Consider the following example: https://git.xeondev.com/LR/C/src/branch/master/src/root.zig#L22-L24

Consider the following example: https://git.xeondev.com/LR/C/src/branch/master/src/root.zig#L22-L24
navi10 commented 2026-03-22 15:26:19 +00:00
Author
First-time contributor
Copy link

ok

ok
navi10 commented 2026-03-23 04:01:27 +00:00
Author
First-time contributor
Copy link

I didn't notice that 'std_optioins' wasn't declared as pub
updated now

I didn't notice that 'std_optioins' wasn't declared as pub updated now
src/root.zig Outdated
@ -58,3 +42,1 @@
\\ %..@.....:@@:@:::-----@@.@..-@@@@.:@@@.@@@@@:#@..::::::+--*
\\ @-.::=....@+:::%::::::::@...@@.@%%.@. --@@..@:@.@...::::@---@
\\@:::::=..+%:::::@.....::@..........@:: .---=@.@#...@....:::@--=@
debug.write(
xeon commented 2026-03-22 15:15:26 +00:00
Owner
Copy link

Hmm, not sure why would you want the ASCII art go to winedbg as well?

Hmm, not sure why would you want the ASCII art go to winedbg as well?
navi10 commented 2026-03-22 15:25:16 +00:00
Author
First-time contributor
Copy link

hmm, you're right haha

hmm, you're right haha
navi10 changed title from feat: better log output for wine to WIP: feat: better log output for wine 2026-03-23 16:20:39 +00:00
navi10 changed title from WIP: feat: better log output for wine to feat: better log output for wine 2026-03-24 06:02:15 +00:00
This pull request can be merged automatically.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u wine_log:navi10-wine_log
git switch navi10-wine_log

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch master
git merge --no-ff navi10-wine_log
git switch navi10-wine_log
git rebase master
git switch master
git merge --ff-only navi10-wine_log
git switch navi10-wine_log
git rebase master
git switch master
git merge --no-ff navi10-wine_log
git switch master
git merge --squash navi10-wine_log
git switch master
git merge --ff-only navi10-wine_log
git switch master
git merge navi10-wine_log
git push origin master
Sign in to join this conversation.
Reviewers
No reviewers
xeon
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
eileen-sr/locomotive!2
No description provided.